Issue 10176004: Make static API getters inlineable again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10176004: Make static API getters inlineable again. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make static API getters inlineable again. This relands r11376 with minor fixes for Windows where offsets are slightly different from Linux for unaligned fields. R=svenpanne@chromium.org TEST=cctest/test-api/StaticGetters Committed: https://code.google.com/p/v8/source/detail?r=11417

Patch Set 1 #

Patch Set 2 : Fix presubmit failure in v8.h. #

Patch Set 3 : Reorder Isolate fields to fix alignment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -32 lines)			Patch
M	include/v8.h	View	1 2	6 chunks	+60 lines, -14 lines	0 comments	Download
M	src/heap.h	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 2	6 chunks	+14 lines, -14 lines	0 comments	Download
M	src/isolate.cc	View	1 2	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/serialize.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Patch Set 1: Original CL https://chromiumcodereview.appspot.com/10116024/ Patch Set 2: Original CL https://chromiumcodereview.appspot.com/10021057/ Patch Set 3: ...

8 years, 8 months ago (2012-04-23 13:20:59 UTC) #1

lgtm

Expand Messages | Collapse Messages