Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/isolate.cc

Issue 10176004: Make static API getters inlineable again. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reorder Isolate fields to fix alignment. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index e80512239d25f0301b1f1575e033f9ea8a5e0974..c4d29ee29445ea1c19a1f28774d20252e74be84a 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1430,6 +1430,7 @@ void Isolate::ThreadDataTable::RemoveAllThreads(Isolate* isolate) {
Isolate::Isolate()
: state_(UNINITIALIZED),
+ embedder_data_(NULL),
entry_stack_(NULL),
stack_trace_nesting_level_(0),
incomplete_message_(NULL),
@@ -1472,7 +1473,6 @@ Isolate::Isolate()
string_tracker_(NULL),
regexp_stack_(NULL),
date_cache_(NULL),
- embedder_data_(NULL),
context_exit_happened_(false) {
TRACE_ISOLATE(constructor);
@@ -1857,6 +1857,13 @@ bool Isolate::Init(Deserializer* des) {
LOG(this, LogCompiledFunctions());
}
+ CHECK_EQ(OFFSET_OF(Isolate, state_),
+ static_cast<intptr_t>(Internals::kIsolateStateOffset));
+ CHECK_EQ(OFFSET_OF(Isolate, embedder_data_),
+ static_cast<intptr_t>(Internals::kIsolateEmbedderDataOffset));
+ CHECK_EQ(OFFSET_OF(Isolate, heap_.roots_),
+ static_cast<intptr_t>(Internals::kIsolateRootsOffset));
+
state_ = INITIALIZED;
time_millis_at_init_ = OS::TimeCurrentMillis();
return true;
« no previous file with comments | « src/isolate.h ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698