Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: runtime/vm/dart_entry.cc

Issue 10175011: Rework mirrors implementation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 6851)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -221,48 +221,6 @@
}
-RawObject* DartLibraryCalls::HandleMirrorsMessage(Dart_Port dest_port_id,
- Dart_Port reply_port_id,
- const Instance& message) {
- Isolate* isolate = Isolate::Current();
- // Create the reply port.
- const Object& reply_port = Object::Handle(
- DartLibraryCalls::NewSendPort(reply_port_id));
- if (reply_port.IsError()) {
- return reply_port.raw();
- }
-
- // Call _Mirrors.processCommand(message, reply_port).
- const Library& lib =
- Library::Handle(isolate->object_store()->mirrors_library());
- const String& raw_class_name =
- String::Handle(String::NewSymbol("_Mirrors"));
- const String& private_key =
- String::Handle(lib.private_key());
- const String& class_name =
- String::Handle(String::Concat(raw_class_name, private_key));
- const String& function_name =
- String::Handle(String::NewSymbol("processCommand"));
- const int kNumArguments = 2;
- const Array& kNoArgumentNames = Array::Handle();
- const Function& function = Function::Handle(
- Resolver::ResolveStatic(lib,
- class_name,
- function_name,
- kNumArguments,
- kNoArgumentNames,
- Resolver::kIsQualified));
- ASSERT(!function.IsNull());
- GrowableArray<const Object*> arguments(kNumArguments);
- arguments.Add(&message);
- arguments.Add(&reply_port);
- const Object& result = Object::Handle(
- DartEntry::InvokeStatic(function, arguments, kNoArgumentNames));
- ASSERT(result.IsNull() || result.IsError());
- return result.raw();
-}
-
-
RawObject* DartLibraryCalls::NewSendPort(intptr_t port_id) {
Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
ASSERT(!isolate_lib.IsNull());
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698