Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: runtime/vm/isolate.cc

Issue 10175011: Rework mirrors implementation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/json.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 6851)
+++ runtime/vm/isolate.cc (working copy)
@@ -6,6 +6,7 @@
#include "include/dart_api.h"
#include "platform/assert.h"
+#include "lib/mirrors.h"
#include "vm/compiler_stats.h"
#include "vm/dart_api_state.h"
#include "vm/dart_entry.h"
@@ -98,18 +99,8 @@
Instance::Handle(DeserializeMessage(message->data()));
if (message->IsOOB()) {
// For now the only OOB messages are Mirrors messages.
- const Object& result = Object::Handle(
- DartLibraryCalls::HandleMirrorsMessage(
- message->dest_port(), message->reply_port(), msg));
+ HandleMirrorsMessage(isolate_, message->reply_port(), msg);
delete message;
- if (result.IsError()) {
- // TODO(turnidge): Propagating the error is probably wrong here.
- Error& error = Error::Handle();
- error ^= result.raw();
- isolate_->object_store()->set_sticky_error(error);
- return false;
- }
- ASSERT(result.IsNull());
} else {
const Object& result = Object::Handle(
DartLibraryCalls::HandleMessage(
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/json.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698