chrome/browser/extensions/browser_extension_window_controller.cc - Issue 10175008: Improving the process model extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 10175008: Improving the process model extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved common functionality to ExtensionTabUtil and more feedback fixes. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_extension_window_controller.cc

diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc

index e0d6a0b82e41821d0d3fe92d29adff88e92e7e2c..eba61d56360a63d51cf362efd602a14094041907 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.cc

+++ b/chrome/browser/extensions/browser_extension_window_controller.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/browser_extension_window_controller.h"

+#include "base/values.h"

Charlie Reis 2012/05/02 00:23:13 Unneeded?

nasko 2012/05/02 18:14:02 Needed, because of the added function to extension

Charlie Reis 2012/05/03 18:47:51 Sounds like this line belongs in extension_tab_uti

nasko 2012/05/03 23:28:04 Done.

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/extension_tabs_module_constants.h"

#include "chrome/browser/profiles/profile.h"