Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 10175008: Improving the process model extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved common functionality to ExtensionTabUtil and more feedback fixes. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/browser_extension_window_controller.h" 5 #include "chrome/browser/extensions/browser_extension_window_controller.h"
6 6
7 #include "base/values.h"
Charlie Reis 2012/05/02 00:23:13 Unneeded?
nasko 2012/05/02 18:14:02 Needed, because of the added function to extension
Charlie Reis 2012/05/03 18:47:51 Sounds like this line belongs in extension_tab_uti
nasko 2012/05/03 23:28:04 Done.
7 #include "chrome/browser/extensions/extension_tab_util.h" 8 #include "chrome/browser/extensions/extension_tab_util.h"
8 #include "chrome/browser/extensions/extension_tabs_module_constants.h" 9 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
9 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sessions/session_id.h" 11 #include "chrome/browser/sessions/session_id.h"
11 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_window.h" 13 #include "chrome/browser/ui/browser_window.h"
13 14
14 BrowserExtensionWindowController::BrowserExtensionWindowController( 15 BrowserExtensionWindowController::BrowserExtensionWindowController(
15 Browser* browser) 16 Browser* browser)
16 : ExtensionWindowController(browser->window(), browser->profile()), 17 : ExtensionWindowController(browser->window(), browser->profile()),
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 59 }
59 return true; 60 return true;
60 } 61 }
61 62
62 void BrowserExtensionWindowController::SetFullscreenMode( 63 void BrowserExtensionWindowController::SetFullscreenMode(
63 bool is_fullscreen, 64 bool is_fullscreen,
64 const GURL& extension_url) const { 65 const GURL& extension_url) const {
65 if (browser_->window()->IsFullscreen() != is_fullscreen) 66 if (browser_->window()->IsFullscreen() != is_fullscreen)
66 browser_->ToggleFullscreenModeWithExtension(extension_url); 67 browser_->ToggleFullscreenModeWithExtension(extension_url);
67 } 68 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698