Improving the process model extension API

chrome/browser/task_manager/task_manager.h

Index: chrome/browser/task_manager/task_manager.h
diff --git a/chrome/browser/task_manager/task_manager.h b/chrome/browser/task_manager/task_manager.h
index fe88a0905a331b1fe9b843d6be1fdbde37c4f941..154c1f2421504681d3092f0ecf3fd4622256af8a 100644
--- a/chrome/browser/task_manager/task_manager.h
+++ b/chrome/browser/task_manager/task_manager.h
@@ -252,6 +252,9 @@ class TaskManagerModelObserver {
   // Invoked when new items are added.
   virtual void OnItemsAdded(int start, int length) = 0;
 
+  // Invoked when a range of items is to be immediately removed.

[Charlie Reis, 2012/04/23 22:19:51]

Worthwhile to add a comment saying why this is useful vs OnItemsRemoved (i.e.,
the resource at that index can still be queried).

[nasko, 2012/04/24 18:14:29]

Done.

+  virtual void OnItemsToBeRemoved(int start, int length) = 0;

[Charlie Reis, 2012/04/23 22:19:51]

Should we make this an empty implementation (like OnReadyPeriodicalUpdate below)
rather than pure virtual?  That would save some changes in the other TaskManager
files.

[nasko, 2012/04/24 18:14:29]

This is a good point. I've made it non-virtual with empty implementation.

+
   // Invoked when a range of items has been removed.
   virtual void OnItemsRemoved(int start, int length) = 0;
 
@@ -334,6 +337,10 @@ class TaskManagerModel : public base::RefCountedThreadSafe<TaskManagerModel> {
   // resource for the given row isn't a renderer.
   bool GetV8Memory(int index, size_t* result) const;
 
+  // Gets the amount of memory used for javascript. Returns false if the
+  // resource for the given row isn't a renderer.
+  bool GetV8MemoryUsed(int index, size_t* result) const;
+
   // Returns true if resource for the given row can be activated.
   bool CanActivate(int index) const;