Improving the process model extension API

chrome/browser/task_manager/task_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_H_
 #define CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_H_
 #pragma once
 
 #include <map>
 #include <utility>
@@ skipping 234 matching lines @@
 
   // Invoked when the model has been completely changed.
   virtual void OnModelChanged() = 0;
 
   // Invoked when a range of items has changed.
   virtual void OnItemsChanged(int start, int length) = 0;
 
   // Invoked when new items are added.
   virtual void OnItemsAdded(int start, int length) = 0;
 
+  // Invoked when a range of items is to be immediately removed.

[Charlie Reis, 2012/04/23 22:19:51]

Worthwhile to add a comment saying why this is useful vs OnItemsRemoved (i.e.,
the resource at that index can still be queried).

[nasko, 2012/04/24 18:14:29]

Done.

+  virtual void OnItemsToBeRemoved(int start, int length) = 0;

[Charlie Reis, 2012/04/23 22:19:51]

Should we make this an empty implementation (like OnReadyPeriodicalUpdate below)
rather than pure virtual?  That would save some changes in the other TaskManager
files.

[nasko, 2012/04/24 18:14:29]

This is a good point. I've made it non-virtual with empty implementation.

+
   // Invoked when a range of items has been removed.
   virtual void OnItemsRemoved(int start, int length) = 0;
 
   // Invoked when the initialization of the model has been finished and
   // periodical updates is started. The first periodical update will be done
   // in a few seconds. (depending on platform)
   virtual void OnReadyPeriodicalUpdate() {}
 };
 
 // The model that the TaskManager is using.
@@ skipping 62 matching lines @@
   bool GetFPS(int index, float* result) const;
 
   // Gets the sqlite memory (in byte). Return false if the resource for the
   // given row doesn't report information.
   bool GetSqliteMemoryUsedBytes(int index, size_t* result) const;
 
   // Gets the amount of memory allocated for javascript. Returns false if the
   // resource for the given row isn't a renderer.
   bool GetV8Memory(int index, size_t* result) const;
 
+  // Gets the amount of memory used for javascript. Returns false if the
+  // resource for the given row isn't a renderer.
+  bool GetV8MemoryUsed(int index, size_t* result) const;
+
   // Returns true if resource for the given row can be activated.
   bool CanActivate(int index) const;
 
   // Returns true if resource for the given row can be inspected using developer
   // tools.
   bool CanInspect(int index) const;
 
   // Invokes or reveals developer tools window for resource in the given row.
   void Inspect(int index) const;
 
@@ skipping 201 matching lines @@
   // A salt lick for the goats.
   uint64 goat_salt_;
 
   // Resource identifier that is unique within single session.
   int last_unique_id_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskManagerModel);
 };
 
 #endif  // CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_H_