Improving the process model extension API

chrome/browser/task_manager/task_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/task_manager.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/i18n/number_formatting.h"
 #include "base/i18n/rtl.h"
@@ skipping 568 matching lines @@
 
 bool TaskManagerModel::GetV8Memory(int index, size_t* result) const {
   *result = 0;
   if (!resources_[index]->ReportsV8MemoryStats())
     return false;
 
   *result = resources_[index]->GetV8MemoryAllocated();
   return true;
 }
 
+bool TaskManagerModel::GetV8MemoryUsed(int index, size_t* result) const {
+  *result = 0;
+  if (!resources_[index]->ReportsV8MemoryStats())
+    return false;
+
+  *result = resources_[index]->GetV8MemoryUsed();
+  return true;
+}
+
 bool TaskManagerModel::CanActivate(int index) const {
   CHECK_LT(index, ResourceCount());
   return GetResourceTabContents(index) != NULL;
 }
 
 bool TaskManagerModel::CanInspect(int index) const {
   CHECK_LT(index, ResourceCount());
   return resources_[index]->CanInspect();
 }
 
@@ skipping 152 matching lines @@
     if (pm_iter != metrics_map_.end()) {
       delete pm_iter->second;
       metrics_map_.erase(process);
     }
     // And we don't need the CPU usage anymore either.
     CPUUsageMap::iterator cpu_iter = cpu_usage_map_.find(process);
     if (cpu_iter != cpu_usage_map_.end())
       cpu_usage_map_.erase(cpu_iter);
   }
 
-  // Remove the entry from the model list.
+  // Prepare to remove the entry from the model list.
   iter = std::find(resources_.begin(), resources_.end(), resource);
   DCHECK(iter != resources_.end());
   int index = static_cast<int>(iter - resources_.begin());
+
+  // Notify the observers that the contents will change.
+  FOR_EACH_OBSERVER(TaskManagerModelObserver, observer_list_,
+                    OnItemsToBeRemoved(index, 1));
+
+  // Now actually remove the entry from the model list.
   resources_.erase(iter);
 
   // Remove the entry from the network maps.
   ResourceValueMap::iterator net_iter =
       current_byte_count_map_.find(resource);
   if (net_iter != current_byte_count_map_.end())
     current_byte_count_map_.erase(net_iter);
   net_iter = displayed_network_usage_map_.find(resource);
   if (net_iter != displayed_network_usage_map_.end())
     displayed_network_usage_map_.erase(net_iter);
@@ skipping 391 matching lines @@
     // Count the number of extensions with background pages (including
     // incognito).
     count += CountExtensionBackgroundPagesForProfile(profile);
     if (profile->HasOffTheRecordProfile()) {
       count += CountExtensionBackgroundPagesForProfile(
           profile->GetOffTheRecordProfile());
     }
   }
   return count;
 }