Add a Profile* member to TemplateURL. This makes some invocations of ReplaceSearchTerms() a bit le…

Add a Profile* member to TemplateURL.  This makes some invocations of ReplaceSearchTerms() a bit less verbose, and will be useful later when UIThreadSearchTermsData starts taking a Profile*.

One downside is that there are a number of const_cast<>()s added when we try to access the profile() of a const TemplateURL*.  These will all go away soon when TemplateURLService is switched to using "const" much less, so I didn't worry too much about them.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133483

[Peter Kasting, 2012-04-20 23:48:08]

ivankr: chrome/browser/protector
mnissler: chrome/browser/policy
atwilson: chrome/browser/sync
sky: rest

[Peter Kasting, 2012-04-20 23:50:12]

Incidentally, for sync, I wound up getting some cleanup stuff mixed in, mainly
moving some helper functions to be file-scoped, and getting rid of some using
directives, because in most cases the code was shorter overall without them, and
then I didn't want to be inconsistent with the last couple and leave them but
not the others.

[Mattias Nissler (ping if slow), 2012-04-23 08:46:33]

chrome/browser/policy LGTM

[Ivan Korotkov, 2012-04-23 14:14:18]

protector/ LGTM

[sky, 2012-04-23 15:08:14]

LGTM

[Andrew T Wilson (Slow), 2012-04-23 16:36:36]

LGTM for browser/sync

https://chromiumcodereview.appspot.com/10173001/diff/15001/chrome/browser/syn...
File chrome/browser/sync/test/integration/search_engines_helper.cc (right):

https://chromiumcodereview.appspot.com/10173001/diff/15001/chrome/browser/syn...
chrome/browser/sync/test/integration/search_engines_helper.cc:260: if
(sync_datatype_helper::test()->use_verifier()) {
This is fine to land, but does it really help readability to explicitly use
namespacing everywhere in this file rather than putting a single
using::sync_datatype_helper::test; at the top?

[Peter Kasting, 2012-04-23 18:14:26]

https://chromiumcodereview.appspot.com/10173001/diff/15001/chrome/browser/syn...
File chrome/browser/sync/test/integration/search_engines_helper.cc (right):

https://chromiumcodereview.appspot.com/10173001/diff/15001/chrome/browser/syn...
chrome/browser/sync/test/integration/search_engines_helper.cc:260: if
(sync_datatype_helper::test()->use_verifier()) {
On 2012/04/23 16:36:36, Andrew T Wilson wrote:
> This is fine to land, but does it really help readability to explicitly use
> namespacing everywhere in this file rather than putting a single
> using::sync_datatype_helper::test; at the top?

I'm not sure, honestly.

The reason I changed this was because I was really confused reading the code
originally and kept looking for some sort of file-scoped or class-scoped member
named test().  It was only after a bit of searching that I noticed the using
statement.

OTOH, omitting it makes the code more verbose, which is also bad.

I'm not sure in the end which consequence is worse.

[Peter Kasting, 2012-04-23 18:25:19]

On 2012/04/23 18:14:26, Peter Kasting wrote:
> I'm not sure in the end which consequence is worse.

I'm going to restore the using statement since I don't want to change the code
if I'm not convinced I'm improving it.