chrome/browser/ui/search_engines/edit_search_engine_controller.cc - Issue 10173001: Add a Profile* member to TemplateURL. This makes some invocations of ReplaceSearchTerms() a bit le…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

Issue 10173001: Add a Profile* member to TemplateURL. This makes some invocations of ReplaceSearchTerms() a bit le… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/search_engines_helper.cc ('K') | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

===================================================================

--- chrome/browser/ui/search_engines/edit_search_engine_controller.cc (revision 132905)

+++ chrome/browser/ui/search_engines/edit_search_engine_controller.cc (working copy)

@@ -43,7 +43,7 @@

// TemplateURLRef::IsValid() when its owner is NULL.

TemplateURLData data;

data.SetURL(url);

- TemplateURL t_url(data);

+ TemplateURL t_url(profile_, data);

const TemplateURLRef& template_ref = t_url.url_ref();

if (!template_ref.IsValid())

return false;

@@ -132,7 +132,7 @@

// we need to replace the search terms before testing for the scheme.

TemplateURLData data;

data.SetURL(url);

- TemplateURL t_url(data);

+ TemplateURL t_url(profile_, data);

std::string expanded_url(t_url.url_ref().ReplaceSearchTerms(ASCIIToUTF16("x"),

TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));

url_parse::Parsed parts;