Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 10171021: ash: Add a shadow for the uber-tray popups. (Closed)

Created:
8 years, 8 months ago by sadrul
Modified:
8 years, 8 months ago
CC:
chromium-reviews, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Add a shadow for the uber-tray popups. BUG=123154, 124861 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134294

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : adjustment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -39 lines) Patch
M ash/system/tray/system_tray.cc View 1 2 5 chunks +84 lines, -37 lines 0 comments Download
M ash/system/tray/tray_empty.cc View 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
8 years, 8 months ago (2012-04-27 04:43:28 UTC) #1
Ben Goodger (Google)
screenshot please!
8 years, 8 months ago (2012-04-27 15:51:13 UTC) #2
sadrul
On 2012/04/27 15:51:13, Ben Goodger (Google) wrote: > screenshot please! http://www.corp.google.com/~sadrul/ubertray/uber-tray-shadow.png
8 years, 8 months ago (2012-04-27 16:03:22 UTC) #3
Ben Goodger (Google)
Looks like there's a sharp cutoff on the left edge. Can you tweak this a ...
8 years, 8 months ago (2012-04-27 16:17:57 UTC) #4
sadrul
8 years, 8 months ago (2012-04-27 17:26:56 UTC) #5
Ben Goodger (Google)
8 years, 8 months ago (2012-04-27 17:27:35 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698