Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10170037: Make GTK Panels ignore mouse/keyboard events after drag is ended until mouse is released. (Closed)

Created:
8 years, 7 months ago by jennb
Modified:
8 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, jianli, dcheng, Andrei
Visibility:
Public.

Description

Make GTK Panels ignore mouse/keyboard events after drag is ended until mouse is released. BUG=125407 TEST=Manually verified repro steps from bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134399

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added guards. Removed dup dcheck. #

Patch Set 3 : Update GTK native panel testing end drag logic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -24 lines) Patch
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_gtk.h View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_gtk.cc View 1 7 chunks +35 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jennb
Verified that this is not a bug on Mac or Windows. Those 2 had logic ...
8 years, 7 months ago (2012-04-27 22:14:21 UTC) #1
Dmitry Titov
http://codereview.chromium.org/10170037/diff/1/chrome/browser/ui/panels/panel_drag_gtk.cc File chrome/browser/ui/panels/panel_drag_gtk.cc (right): http://codereview.chromium.org/10170037/diff/1/chrome/browser/ui/panels/panel_drag_gtk.cc#newcode197 chrome/browser/ui/panels/panel_drag_gtk.cc:197: void PanelDragGtk::ReleasePointerAndKeyboardGrab() { This function can be called twice ...
8 years, 7 months ago (2012-04-27 22:28:32 UTC) #2
jennb
http://codereview.chromium.org/10170037/diff/1/chrome/browser/ui/panels/panel_drag_gtk.cc File chrome/browser/ui/panels/panel_drag_gtk.cc (right): http://codereview.chromium.org/10170037/diff/1/chrome/browser/ui/panels/panel_drag_gtk.cc#newcode197 chrome/browser/ui/panels/panel_drag_gtk.cc:197: void PanelDragGtk::ReleasePointerAndKeyboardGrab() { On 2012/04/27 22:28:32, Dmitry Titov wrote: ...
8 years, 7 months ago (2012-04-27 22:52:06 UTC) #3
Dmitry Titov
8 years, 7 months ago (2012-04-27 23:20:17 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698