Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/ui/panels/panel_drag_gtk.h

Issue 10170037: Make GTK Panels ignore mouse/keyboard events after drag is ended until mouse is released. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update GTK native panel testing end drag logic. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | chrome/browser/ui/panels/panel_drag_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_drag_gtk.h
diff --git a/chrome/browser/ui/panels/panel_drag_gtk.h b/chrome/browser/ui/panels/panel_drag_gtk.h
index f2ea5e650417f961596bf0a28ce73fa9cc1145c4..6ca655a5856572a0c5d1bf5badf74e99c3e2ce2e 100644
--- a/chrome/browser/ui/panels/panel_drag_gtk.h
+++ b/chrome/browser/ui/panels/panel_drag_gtk.h
@@ -48,7 +48,8 @@ class PanelDragGtk {
enum DragState {
NOT_DRAGGING,
- DRAG_IN_PROGRESS
+ DRAG_IN_PROGRESS,
+ DRAG_ENDED_WAITING_FOR_MOUSE_RELEASE
};
// Callbacks for GTK mouse and key events.
@@ -71,9 +72,13 @@ class PanelDragGtk {
void GrabPointerAndKeyboard(GdkEventButton* event,
GdkCursor* cursor);
+ void ReleasePointerAndKeyboardGrab();
// Ends any drag that is currently in progress (if any).
- // Also resets all drag state.
+ // Resets all drag state except for pointer and keyboard grabs.
+ // The grabs are released when the mouse is released to prevent a
+ // mouse release *after* the drag has ended (e.g. via ESC key) from
+ // being treated as a mouse click.
void EndDrag(bool canceled);
// Weak pointer to the panel being dragged.
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | chrome/browser/ui/panels/panel_drag_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698