Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10170001: Find feature for tracing, at long last. (Closed)

Created:
8 years, 8 months ago by nduca
Modified:
8 years, 8 months ago
Reviewers:
jbates
CC:
chromium-reviews, tfarina, arv (Not doing code reviews)
Base URL:
git://localhost/home/nduca/Local/chrome/src@master
Visibility:
Public.

Description

Find feature for tracing, at long last. BUG=104567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133308

Patch Set 1 #

Patch Set 2 : Tweak zoom level on focus #

Total comments: 1

Patch Set 3 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+912 lines, -225 lines) Patch
A + chrome/browser/resources/tracing/interactive_tests.html View 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/resources/tracing/kernel_trace_viewer.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/tracing/linux_perf_importer_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/tracing/overlay.js View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/resources/tracing/overlay_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/tracing/profiling_view.css View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/tracing/profiling_view.js View 4 chunks +10 lines, -23 lines 0 comments Download
M chrome/browser/resources/tracing/profiling_view_test.html View 5 chunks +37 lines, -63 lines 0 comments Download
M chrome/browser/resources/tracing/test_utils.js View 1 chunk +21 lines, -1 line 0 comments Download
M chrome/browser/resources/tracing/tests.html View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/tracing/timeline.js View 1 5 chunks +60 lines, -5 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_model.js View 6 chunks +22 lines, -4 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_model_test.html View 3 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_test.html View 1 chunk +58 lines, -67 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_track.js View 4 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/resources/tracing/timeline_track_test.html View 1 2 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view.css View 2 chunks +61 lines, -7 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view.js View 1 7 chunks +307 lines, -4 lines 0 comments Download
A chrome/browser/resources/tracing/timeline_view_test.html View 1 1 chunk +257 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nduca
Mega mega. ~sigh~
8 years, 8 months ago (2012-04-20 09:59:04 UTC) #1
jbates
8 years, 8 months ago (2012-04-20 22:05:06 UTC) #2 
lgtm

http://codereview.chromium.org/10170001/diff/2001/chrome/browser/resources/tr...
File chrome/browser/resources/tracing/timeline_track_test.html (right):

http://codereview.chromium.org/10170001/diff/2001/chrome/browser/resources/tr...
chrome/browser/resources/tracing/timeline_track_test.html:102: var hits =
track.findAllObjectsMatchingFilter(new tracing.TimelineFilter("b"));
nit: 80 chars

Powered by Google App Engine
This is Rietveld 408576698