chrome/browser/resources/tracing/overlay.js - Issue 10170001: Find feature for tracing, at long last.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/tracing/overlay.js

Issue 10170001: Find feature for tracing, at long last. (Closed) Base URL: git://localhost/home/nduca/Local/chrome/src@master

Patch Set: patch for landing Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/tracing/overlay.js

diff --git a/chrome/browser/resources/tracing/overlay.js b/chrome/browser/resources/tracing/overlay.js

index bcf377111e951e0a68f4d30815fd2009f44dd804..1a911a83911cbeb931fd43bd0756553c6acbc7da 100644

--- a/chrome/browser/resources/tracing/overlay.js

+++ b/chrome/browser/resources/tracing/overlay.js

@@ -56,7 +56,12 @@ cr.define('tracing', function() {

// Bring overlay into focus.

overlay.tabIndex = 0;

- overlay.focus();

+ var focusElement =

+ overlay.querySelector('button, input, list, select, a');

+ if (!focusElement) {

+ focusElement = overlay;

+ }

+ focusElement.focus();

// Listen to key and focus events to prevent focus from

// leaving the overlay.