Unify ChromeOS/non-ChromeOS strings into one label on sync_ui_util

Unify ChromeOS/non-ChromeOS strings into one label on sync_ui_util

BUG=none
TEST=build with chromeos=0/1 use_titlecase=0/1


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133606

[kochi, 2012-04-23 08:02:50]

Hi Alexey,

Is this change what you meant in TODO?

[altimofeev, 2012-04-23 08:19:09]

Yes, it is exactly what I meant. Thanks for fixing.
LGTM in general, but please be sure that this works on Chromeos - at least run
"linux_chromeos" and "linux_chromeos_clang" bots.

https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
chrome/app/generated_resources.grd:11507: +	<if expr="not pp_ifdef('chromeos')">
When I was making this change, nested 'if' tags caused compilation error. Have
you tested this code path?

https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
chrome/app/generated_resources.grd:11538: +	<if expr="not pp_ifdef('chromeos')">
same here

[kochi, 2012-04-23 08:53:59]

On 2012/04/23 08:19:09, altimofeev wrote:
> Yes, it is exactly what I meant. Thanks for fixing.
> LGTM in general, but please be sure that this works on Chromeos - at least run
> "linux_chromeos" and "linux_chromeos_clang" bots.
> 
>
https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
> File chrome/app/generated_resources.grd (right):
> 
>
https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
> chrome/app/generated_resources.grd:11507: +	<if expr="not
pp_ifdef('chromeos')">
> When I was making this change, nested 'if' tags caused compilation error. Have
> you tested this code path?
> 
>
https://chromiumcodereview.appspot.com/10167025/diff/2001/chrome/app/generate...
> chrome/app/generated_resources.grd:11538: +	<if expr="not
pp_ifdef('chromeos')">
> same here

Thanks for your review!
I tried compiling with both chromeos=1 and use_titlecase=1 so it seems
compiling but looking around the file it looks not nesting <if>s is the
convention.

Updated the CL.

[altimofeev, 2012-04-23 08:58:06]

OK. Still LGTM.

[kochi, 2012-04-23 10:06:48]

On 2012/04/23 08:58:06, altimofeev wrote:
> OK. Still LGTM.

Thanks!

Carlos, could you give OWNERS lgtm for generated_resources.grd?

Tim or Richard, could you give OWNERS lgtm for sync?

[rlarocque, 2012-04-23 18:30:14]

On 2012/04/23 10:06:48, Takayoshi Kochi wrote:
> On 2012/04/23 08:58:06, altimofeev wrote:
> > OK. Still LGTM.
> 
> Thanks!
> 
> Carlos, could you give OWNERS lgtm for generated_resources.grd?
> 
> Tim or Richard, could you give OWNERS lgtm for sync?

LGTM

[cpu_(ooo_6.6-7.5), 2012-04-24 00:29:38]

RS LGTM

[commit-bot: I haz the power, 2012-04-24 00:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10167025/8001

[commit-bot: I haz the power, 2012-04-24 02:19:42]

Change committed as 133606