Issue 10166021: fix incremental_chrome_dll shared build on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10166021: fix incremental_chrome_dll shared build on windows (Closed)

Created:
8 years, 8 months ago by Dirk Pranke

Modified:
8 years, 8 months ago

Reviewers:
Roger Tawa OOO till Jul 10th, Vangelis Kokkevis, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

fix incremental_chrome_dll shared build on windows This patch applies patchset #2 from https://chromiumcodereview.appspot.com/10121004/ and then removes the changes to content_switches.cc (which weren't needed) and chrome_exe.gypi (which was not needed and was actually bad because it caused chrome.exe to depend on content.dll ). R=jam@chromium.org, vangelis@chromium.org, rogerta@chromium.org BUG=none TEST=local win build succeeds with incremental_chrome_dll = 1, all bots remain green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134008

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
M	build/common.gypi	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm