Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: build/common.gypi

Issue 10166021: fix incremental_chrome_dll shared build on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reformat from a linux machine?? Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 429438efb7a5a6686e26fb42995553350b926159..930c35a7ee902734da09499a7b22e9b4eec065be 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1203,14 +1203,6 @@
['component=="shared_library"', {
'defines': ['COMPONENT_BUILD'],
}],
- ['component=="shared_library" and incremental_chrome_dll==1', {
- # TODO(dpranke): We can't incrementally link chrome when
- # content is being built as a DLL because chrome links in
- # webkit_glue and webkit_glue depends on symbols defined in
- # content. We can remove this when we fix glue.
- # See http://code.google.com/p/chromium/issues/detail?id=98755 .
- 'defines': ['COMPILE_CONTENT_STATICALLY'],
- }],
['toolkit_views==1', {
'defines': ['TOOLKIT_VIEWS=1'],
}],
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698