Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: runtime/bin/http_impl.dart

Issue 10164001: Unregister callbacks from socket, when we return the socket for reuse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/http_impl.dart
diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart
index 05b1a38b8f105e79425e52d2d345704c36ab6d06..683746ebe9f172463116c51b44fc0e7e36c90cc5 100644
--- a/runtime/bin/http_impl.dart
+++ b/runtime/bin/http_impl.dart
@@ -1111,6 +1111,9 @@ class _HttpClientConnection
_socket.close();
}
} else {
+ _socket.onData = null;
Søren Gjesse 2012/04/20 11:07:22 _returnSocketConnection already does this (calls _
Anders Johnsen 2012/04/20 11:13:42 It's done iff shutdown is not marked. Is there a o
Søren Gjesse 2012/04/20 11:27:35 How about just moving the _markReturned to the top
+ _socket.onClosed = null;
+ _socket.onError = null;
_client._returnSocketConnection(_socketConn);
}
_socket = null;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698