Unregister callbacks from socket, when we return the socket for reuse.

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _HttpHeaders implements HttpHeaders {
   _HttpHeaders() : _headers = new Map<String, List<String>>();
 
   List<String> operator[](String name) {
     name = name.toLowerCase();
     return _headers[name];
@@ skipping 1093 matching lines @@
     // Tell the HTTP parser the method it is expecting a response to.
     _httpParser.responseToMethod = _method;
   }
 
   void _responseDone() {
     if (_closing) {
       if (_socket != null) {
         _socket.close();
       }
     } else {
+      _socket.onData = null;

[Søren Gjesse, 2012/04/20 11:07:22]

_returnSocketConnection already does this (calls _markReturned as its last
action).

[Anders Johnsen, 2012/04/20 11:13:42]

It's done iff shutdown is not marked. Is there a odd chance that socket will
send out onData/onClosed after a close() call?

[Søren Gjesse, 2012/04/20 11:27:35]

How about just moving the _markReturned to the top of _returnSocketConnection?

+      _socket.onClosed = null;
+      _socket.onError = null;
       _client._returnSocketConnection(_socketConn);
     }
     _socket = null;
     _socketConn = null;
   }
 
   HttpClientRequest open(String method, String uri) {
     _method = method;
     _request = new _HttpClientRequest(method, uri, this);
     _response = new _HttpClientResponse(this);
@@ skipping 266 matching lines @@
     sockets.addFirst(socketConn);
     socketConn._markReturned();
   }
 
   Function _onOpen;
   Map<String, Queue<_SocketConnection>> _openSockets;
   Set<_SocketConnection> _activeSockets;
   Timer _evictionTimer;
   bool _shutdown;  // Has this HTTP client been shutdown?
 }