Issue 10163003: Put new global var semantics behind a flag until WebKit tests are cleaned up.

Issue 10163003: Put new global var semantics behind a flag until WebKit tests are cleaned up. (Closed)

Created:
8 years, 8 months ago by rossberg

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Put new global var semantics behind a flag until WebKit tests are cleaned up. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11402

Patch Set 2 : Addressed Michael's comments (and oops, rebased too early). #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
M	src/flag-definitions.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/declare-locally.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-1119.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-115452.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-1170.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. If that (temporary) fixes all the WebKit failures. https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h#newcode135 src/flag-definitions.h:135: ...

8 years, 8 months ago (2012-04-20 13:28:45 UTC) #2

rossberg

8 years, 8 months ago (2012-04-20 14:01:07 UTC) #3

https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h...
src/flag-definitions.h:135: DEFINE_bool(es52_globals, false, "activate new
semantics for global var declarations")
On 2012/04/20 13:28:45, Michael Starzinger wrote:
> Longer than 80 characters.

Done.

https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-api.c...
test/cctest/test-api.cc:12486: v8::internal::FLAG_es52_globals = true;
On 2012/04/20 13:28:45, Michael Starzinger wrote:
> Can we just use "i::FLAG_es52_globals"?

Done.

https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls.cc
File test/cctest/test-decls.cc (right):

https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls...
test/cctest/test-decls.cc:524: v8::internal::FLAG_es52_globals = true;
On 2012/04/20 13:28:45, Michael Starzinger wrote:
> Likewise.

Done.

https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls...
test/cctest/test-decls.cc:587: v8::internal::FLAG_es52_globals = true;
On 2012/04/20 13:28:45, Michael Starzinger wrote:
> Likewise.

Done.

Expand Messages | Collapse Messages