src/runtime.cc - Issue 10163003: Put new global var semantics behind a flag until WebKit tests are cleaned up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 10163003: Put new global var semantics behind a flag until WebKit tests are cleaned up. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Michael's comments (and oops, rebased too early). Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index a344b28e0a030bcfc2410849ad8fa5a65b26153e..1772fb791305ce1ded0876a225b1cc7be0c02347 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1300,7 +1300,10 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_DeclareGlobals) {

// value of the variable if the property is already there.

// Do the lookup locally only, see ES5 errata.

LookupResult lookup(isolate);

- global->LocalLookup(*name, &lookup);

+ if (FLAG_es52_globals)

+ global->LocalLookup(*name, &lookup);

+ else

+ global->Lookup(*name, &lookup);

if (lookup.IsProperty()) {

// We found an existing property. Unless it was an interceptor

// that claims the property is absent, skip this declaration.

« no previous file with comments | « src/flag-definitions.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »