Making sure that UAC promts fired by the Chromoting plugin get focus (instead of being shown in the…

remoting/host/plugin/daemon_installer_win.h

Index: remoting/host/plugin/daemon_installer_win.h
diff --git a/remoting/host/plugin/daemon_installer_win.h b/remoting/host/plugin/daemon_installer_win.h
index aeac8299720b9f14ef3b8966d84f0ecc6b62e4b1..ecc708c92dbd40ff89eb91473b97cb1dc63a2b95 100644
--- a/remoting/host/plugin/daemon_installer_win.h
+++ b/remoting/host/plugin/daemon_installer_win.h
@@ -26,7 +26,8 @@ class DaemonInstallerWin {
   // Creates an instance of the Chromoting Host installer passing the completion
   // callback to be called when the installation finishes. In case of an error
   // returns NULL and passed the error code to |done|.
-  static scoped_ptr<DaemonInstallerWin> Create(CompletionCallback done);
+  static scoped_ptr<DaemonInstallerWin> Create(void* window_handle,

[Jamie, 2012/04/25 21:20:37]

HWND?

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+                                               CompletionCallback done);

[Jamie, 2012/04/25 21:20:37]

Unrelated to this CL, but I don't understand why we're using a factory pattern
for this class. For the controller its because the same interface is used
cross-platform, but it seems like we could just use "new" to instantiate this
class.

[alexeypa (please no reviews), 2012/04/25 21:59:24]

There are two different installer classes: DaemonCommandLineInstallerWin and
DaemonComInstallerWin

 
  protected:
   DaemonInstallerWin(const CompletionCallback& done);
@@ -42,6 +43,11 @@ class DaemonInstallerWin {
   DISALLOW_COPY_AND_ASSIGN(DaemonInstallerWin);
 };
 
+// Returns the first top-level (i.e. WS_OVERLAPPED or WS_POPUP) window is

[Jamie, 2012/04/25 21:20:37]

Nit: s/is/in/

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+// the chain of parents of |window|. Returns |window| if it is itself represent

[Jamie, 2012/04/25 21:20:37]

Nit: "if it is itself a top-level" or "if it represents a top-level"

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+// a top-level window. Returns NULL when |window| is NULL.
+HWND GetTopLevelWindow(HWND window);
+
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_DAEMON_INSTALLER_WIN_H_