Making sure that UAC promts fired by the Chromoting plugin get focus (instead of being shown in the…

remoting/host/plugin/daemon_installer_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_DAEMON_INSTALLER_WIN_H_
 #define REMOTING_HOST_DAEMON_INSTALLER_WIN_H_
 
 #include <objbase.h>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "remoting/host/plugin/daemon_controller.h"
 
 namespace remoting {
 
 class DaemonInstallerWin {
  public:
   typedef base::Callback<void (HRESULT result)> CompletionCallback;
 
   virtual ~DaemonInstallerWin();
 
   // Initiates download and installation of the Chromoting Host.
   virtual void Install() = 0;
 
   // Creates an instance of the Chromoting Host installer passing the completion
   // callback to be called when the installation finishes. In case of an error
   // returns NULL and passed the error code to |done|.
-  static scoped_ptr<DaemonInstallerWin> Create(CompletionCallback done);
+  static scoped_ptr<DaemonInstallerWin> Create(void* window_handle,

[Jamie, 2012/04/25 21:20:37]

HWND?

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+                                               CompletionCallback done);

[Jamie, 2012/04/25 21:20:37]

Unrelated to this CL, but I don't understand why we're using a factory pattern
for this class. For the controller its because the same interface is used
cross-platform, but it seems like we could just use "new" to instantiate this
class.

[alexeypa (please no reviews), 2012/04/25 21:59:24]

There are two different installer classes: DaemonCommandLineInstallerWin and
DaemonComInstallerWin

 
  protected:
   DaemonInstallerWin(const CompletionCallback& done);
 
   // Invokes the completion callback to report the installation result.
   void Done(HRESULT result);
 
  private:
   // The completion callback that should be called to report the installation
   // result.
   CompletionCallback done_;
 
   DISALLOW_COPY_AND_ASSIGN(DaemonInstallerWin);
 };
 
+// Returns the first top-level (i.e. WS_OVERLAPPED or WS_POPUP) window is

[Jamie, 2012/04/25 21:20:37]

Nit: s/is/in/

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+// the chain of parents of |window|. Returns |window| if it is itself represent

[Jamie, 2012/04/25 21:20:37]

Nit: "if it is itself a top-level" or "if it represents a top-level"

[alexeypa (please no reviews), 2012/04/25 21:59:24]

Done.

+// a top-level window. Returns NULL when |window| is NULL.
+HWND GetTopLevelWindow(HWND window);
+
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_DAEMON_INSTALLER_WIN_H_