Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6275)

Unified Diff: chrome/browser/ssl/ssl_add_cert_handler.cc

Issue 10160007: Parse an application/x-x509-user-cert response with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add back a blank line deleted by accident Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_add_cert_handler.cc
===================================================================
--- chrome/browser/ssl/ssl_add_cert_handler.cc (revision 133822)
+++ chrome/browser/ssl/ssl_add_cert_handler.cc (working copy)
@@ -39,6 +39,10 @@
SSLAddCertHandler::~SSLAddCertHandler() {}
void SSLAddCertHandler::Run() {
+ // TODO(wtc): if cert_ is NULL, it means we could not decode the
+ // application/x-x509-user-cert response. db.CheckUserCert() will
+ // return net::ERR_CERT_INVALID. We should add a more informative
+ // error code.
int cert_error;
{
net::CertDatabase db;

Powered by Google App Engine
This is Rietveld 408576698