Parse an application/x-x509-user-cert response with

chrome/browser/ssl/ssl_add_cert_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_add_cert_handler.h"
 
 #include "base/bind.h"
 #include "chrome/browser/tab_contents/tab_contents_ssl_helper.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
@@ skipping 21 matching lines @@
   AddRef();
   // Delay adding the certificate until the next mainloop iteration.
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&SSLAddCertHandler::Run, this));
 }
 
 SSLAddCertHandler::~SSLAddCertHandler() {}
 
 void SSLAddCertHandler::Run() {
+  // TODO(wtc): if cert_ is NULL, it means we could not decode the
+  // application/x-x509-user-cert response.  db.CheckUserCert() will
+  // return net::ERR_CERT_INVALID.  We should add a more informative
+  // error code.
   int cert_error;
   {
     net::CertDatabase db;
     cert_error = db.CheckUserCert(cert_);
   }
   if (cert_error != net::OK) {
     LOG_IF(ERROR, cert_error == net::ERR_NO_PRIVATE_KEY_FOR_CERT)
         << "No corresponding private key in store for cert: "
         << (cert_.get() ? cert_->subject().GetDisplayName() : "NULL");
 
@@ skipping 58 matching lines @@
       TabContentsWrapper::GetCurrentWrapperForContents(tab);
   if (add_cert) {
     if (cert_error == net::OK) {
       wrapper->ssl_helper()->OnAddClientCertificateSuccess(this);
     } else {
       wrapper->ssl_helper()->OnAddClientCertificateError(this, cert_error);
     }
   }
   wrapper->ssl_helper()->OnAddClientCertificateFinished(this);
 }