Issue 10158002: Scons: Remove duplication of VALIDATOR_LIBS list and use library_deps.py instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10158002: Scons: Remove duplication of VALIDATOR_LIBS list and use library_deps.py instead (Closed)

Created:
8 years, 8 months ago by Mark Seaborn

Modified:
8 years, 8 months ago

Reviewers:
Nick Bray, pasko-google - do not use, Nick Bray (chromium)

CC:
native-client-reviews_googlegroups.com, pasko-google - do not use

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Scons: Remove duplication of VALIDATOR_LIBS list and use library_deps.py instead BUG=none TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8332

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -57 lines)			Patch
M	site_scons/site_tools/library_deps.py	View	1	3 chunks	+10 lines, -1 line	0 comments	Download
M	src/trusted/service_runtime/build.scons	View	1	7 chunks	+0 lines, -14 lines	0 comments	Download
M	tests/custom_desc/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	tests/minnacl/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	tests/multiple_sandboxes/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	tests/trusted_crash/osx_crash_filter/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	tests/trusted_crash/osx_crash_forwarding/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	tests/trusted_crash/win_crash_in_syscall/nacl.scons	View	1	2 chunks	+1 line, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

pasko-google - do not use

8 years, 8 months ago (2012-04-20 09:49:33 UTC) #3

LGTM, thanks

the change is smaller than I expected