Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: tests/trusted_crash/osx_crash_filter/nacl.scons

Issue 10158002: Scons: Remove duplication of VALIDATOR_LIBS list and use library_deps.py instead (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Copyright Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/multiple_sandboxes/nacl.scons ('k') | tests/trusted_crash/osx_crash_forwarding/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/trusted_crash/osx_crash_filter/nacl.scons
diff --git a/tests/trusted_crash/osx_crash_filter/nacl.scons b/tests/trusted_crash/osx_crash_filter/nacl.scons
index a82f3c0e979e936d740f979de2b79a75d0da8feb..c8ac31927eb15462e7cb8fffa1c703e6f4bf609a 100644
--- a/tests/trusted_crash/osx_crash_filter/nacl.scons
+++ b/tests/trusted_crash/osx_crash_filter/nacl.scons
@@ -23,12 +23,6 @@ trusted_env = env['TRUSTED_ENV']
# This duplicates the library list in src/trusted/service_runtime/build.scons.
# We would not have to do this if we could get Scons to track dependencies
# between libraries.
-VALIDATOR_LIBS = []
-if trusted_env.Bit('target_x86'):
- VALIDATOR_LIBS += [trusted_env.NaClTargetArchSuffix('ncvalidate')]
-elif trusted_env.Bit('target_arm'):
- VALIDATOR_LIBS += ['ncvalidate_arm_v2']
-
runner = trusted_env.ComponentProgram(
'crash_filter_test', ['crash_filter_test.c'],
EXTRA_LIBS=['sel',
@@ -48,7 +42,7 @@ runner = trusted_env.ComponentProgram(
'platform',
'platform_qual_lib',
'gio',
- ] + VALIDATOR_LIBS)
+ ])
untrusted_crash_nexe = env.File('${STAGING_DIR}/crash_test${PROGSUFFIX}')
trusted_crash_nexe = env.File('${STAGING_DIR}/crash_in_syscall${PROGSUFFIX}')
« no previous file with comments | « tests/multiple_sandboxes/nacl.scons ('k') | tests/trusted_crash/osx_crash_forwarding/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698