Add the navigation redirect-chain to Sync sessions proto for offline analysis.

content/browser/frame_host/navigation_controller_impl_unittest.cc

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index 7a77cd69ab39ad3cf036b518383c4fb60f33c76b..d812d9b19d3854d8de3627121285e4eaa3f9169b 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -1313,13 +1313,13 @@ TEST_F(NavigationControllerTest, ResetEntryValuesAfterCommit) {
   pending_entry->set_is_renderer_initiated(true);
   pending_entry->set_transferred_global_request_id(transfer_id);
   pending_entry->set_should_replace_entry(true);
-  pending_entry->set_redirect_chain(redirects);
+  pending_entry->SetRedirectChain(redirects);
   pending_entry->set_should_clear_history_list(true);
   EXPECT_EQ(post_data.get(), pending_entry->GetBrowserInitiatedPostData());
   EXPECT_TRUE(pending_entry->is_renderer_initiated());
   EXPECT_EQ(transfer_id, pending_entry->transferred_global_request_id());
   EXPECT_TRUE(pending_entry->should_replace_entry());
-  EXPECT_EQ(1U, pending_entry->redirect_chain().size());
+  EXPECT_EQ(1U, pending_entry->GetRedirectChain().size());
   EXPECT_TRUE(pending_entry->should_clear_history_list());
 
   main_test_rfh()->SendNavigate(0, url1);
@@ -1334,7 +1334,7 @@ TEST_F(NavigationControllerTest, ResetEntryValuesAfterCommit) {
   EXPECT_EQ(GlobalRequestID(-1, -1),
             committed_entry->transferred_global_request_id());
   EXPECT_FALSE(committed_entry->should_replace_entry());
-  EXPECT_EQ(0U, committed_entry->redirect_chain().size());
+  EXPECT_EQ(0U, committed_entry->GetRedirectChain().size());

[Charlie Reis, 2014/03/31 22:06:08]

I thought you were preserving this after commit now?

[donnd, 2014/04/01 04:36:26]

This test includes both a ResetForCommit and also does a navigation.  Since we
now pick up the redirects exclusively from the navigation parameters those need
to be supplied for the data to show up at the end.  I added a test method to do
this, and another clause to this test.  

What do you think now?

[Charlie Reis, 2014/04/05 00:09:10]

1) I don't think a check for GetRedirectChain belongs in this particular test
anymore, since this test is about what's cleared by ResetForCommit.

2) I'm still a bit puzzled how the redirect chain can be correct (non-empty)
while pending but then we completely forget it when the commit comes in.  I
guess we just let the commit message trump anything we've seen in the interim? 
(I guess that's just existing behavior, though, so I won't ask for it to be
changed here.)

[donnd, 2014/04/08 21:38:27]

Made a separate test that the redirect chain is preserved.

Yes, I think the existing behavior to clear the redirects on commit was just the
simplest way to prevent it from being used in subsequent navigations.  Since we
need to preserve the chain for sync, we've moved that logic into
MakeNavigateParams.

   EXPECT_FALSE(committed_entry->should_clear_history_list());
 }