Add the navigation redirect-chain to Sync sessions proto for offline analysis.

content/browser/frame_host/navigation_controller_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
@@ skipping 1295 matching lines @@
   std::vector<GURL> redirects;
   redirects.push_back(GURL("http://foo2"));
 
   // Set non-persisted values on the pending entry.
   NavigationEntryImpl* pending_entry =
       NavigationEntryImpl::FromNavigationEntry(controller.GetPendingEntry());
   pending_entry->SetBrowserInitiatedPostData(post_data.get());
   pending_entry->set_is_renderer_initiated(true);
   pending_entry->set_transferred_global_request_id(transfer_id);
   pending_entry->set_should_replace_entry(true);
-  pending_entry->set_redirect_chain(redirects);
+  pending_entry->SetRedirectChain(redirects);
   pending_entry->set_should_clear_history_list(true);
   EXPECT_EQ(post_data.get(), pending_entry->GetBrowserInitiatedPostData());
   EXPECT_TRUE(pending_entry->is_renderer_initiated());
   EXPECT_EQ(transfer_id, pending_entry->transferred_global_request_id());
   EXPECT_TRUE(pending_entry->should_replace_entry());
-  EXPECT_EQ(1U, pending_entry->redirect_chain().size());
+  EXPECT_EQ(1U, pending_entry->GetRedirectChain().size());
   EXPECT_TRUE(pending_entry->should_clear_history_list());
 
   main_test_rfh()->SendNavigate(0, url1);
 
   // Certain values that are only used for pending entries get reset after
   // commit.
   NavigationEntryImpl* committed_entry =
       NavigationEntryImpl::FromNavigationEntry(
           controller.GetLastCommittedEntry());
   EXPECT_FALSE(committed_entry->GetBrowserInitiatedPostData());
   EXPECT_FALSE(committed_entry->is_renderer_initiated());
   EXPECT_EQ(GlobalRequestID(-1, -1),
             committed_entry->transferred_global_request_id());
   EXPECT_FALSE(committed_entry->should_replace_entry());
-  EXPECT_EQ(0U, committed_entry->redirect_chain().size());
+  EXPECT_EQ(0U, committed_entry->GetRedirectChain().size());

[Charlie Reis, 2014/03/31 22:06:08]

I thought you were preserving this after commit now?

[donnd, 2014/04/01 04:36:26]

This test includes both a ResetForCommit and also does a navigation.  Since we
now pick up the redirects exclusively from the navigation parameters those need
to be supplied for the data to show up at the end.  I added a test method to do
this, and another clause to this test.  

What do you think now?

[Charlie Reis, 2014/04/05 00:09:10]

1) I don't think a check for GetRedirectChain belongs in this particular test
anymore, since this test is about what's cleared by ResetForCommit.

2) I'm still a bit puzzled how the redirect chain can be correct (non-empty)
while pending but then we completely forget it when the commit comes in.  I
guess we just let the commit message trump anything we've seen in the interim? 
(I guess that's just existing behavior, though, so I won't ask for it to be
changed here.)

[donnd, 2014/04/08 21:38:27]

Made a separate test that the redirect chain is preserved.

Yes, I think the existing behavior to clear the redirects on commit was just the
simplest way to prevent it from being used in subsequent navigations.  Since we
need to preserve the chain for sync, we've moved that logic into
MakeNavigateParams.

   EXPECT_FALSE(committed_entry->should_clear_history_list());
 }
 
 // Tests what happens when we navigate back successfully
 TEST_F(NavigationControllerTest, Back) {
   NavigationControllerImpl& controller = controller_impl();
   TestNotificationTracker notifications;
   RegisterForAllNavNotifications(&notifications, &controller);
 
   const GURL url1("http://foo1");
@@ skipping 2669 matching lines @@
   EXPECT_EQ(1, controller.GetEntryCount());
   EXPECT_EQ(0, controller.GetCurrentEntryIndex());
   EXPECT_EQ(0, controller.GetLastCommittedEntryIndex());
   EXPECT_EQ(-1, controller.GetPendingEntryIndex());
   EXPECT_FALSE(controller.CanGoBack());
   EXPECT_FALSE(controller.CanGoForward());
   EXPECT_EQ(url4, controller.GetVisibleEntry()->GetURL());
 }
 
 }  // namespace content