Issue 10154002: Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10154002: Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win. (Closed)

Created:
8 years, 8 months ago by Hironori Bono

Modified:
8 years, 8 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/

Visibility:
Public.

More Reviews

Description

Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win. https://bugs.webkit.org/show_bug.cgi?id=83227 Reviewed by Kent Tamura. Source/WebCore: Disable kashida justification if using Skia to draw. Test: fast/text/international/arabic-justify.html * platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::justify): LayoutTests: * fast/text/international/arabic-justify.html: Added. * platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added. * platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added. * platform/chromium/test_expectations.txt: * platform/gtk/fast/text/international/arabic-justify-expected.txt: Added. * platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added. * platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added. * platform/mac/fast/text/international/arabic-justify-expected.txt: Added. * platform/qt/fast/text/international/arabic-justify-expected.txt: Added. TBR=xji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114709

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp	View		1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages