Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10147003: [Sync] Move 'syncapi_core' and 'sync_unit_tests' targets to sync/ (Closed)

Created:
8 years, 8 months ago by akalin
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), dhollowa+watch_chromium.org
Visibility:
Public.

Description

[Sync] Move 'syncapi_core' and 'sync_unit_tests' targets to sync/ Also move related test files. Lock down deps for sync/internal_api. Clean up some deps on chrome/browser/sync. BUG=117585 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133349

Patch Set 1 #

Patch Set 2 : sync to head #

Total comments: 6

Patch Set 3 : Address comments #

Patch Set 4 : remove dep line #

Patch Set 5 : Sync to head #

Patch Set 6 : Remove another read_node_mock reference #

Patch Set 7 : Separate out mock_read_node change #

Patch Set 8 : Remove refs to mock_read_node, this time for real #

Patch Set 9 : Fix Win update errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -10567 lines) Patch
M build/all.gyp View 1 10 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/api/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/api/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/DEPS View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/backend_data_type_configurer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/sync/internal_api/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/sync/internal_api/README View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/sync/internal_api/all_status.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/sync/internal_api/all_status.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/sync/internal_api/base_node.h View 1 2 3 4 1 chunk +0 lines, -255 lines 0 comments Download
D chrome/browser/sync/internal_api/base_node.cc View 1 chunk +0 lines, -346 lines 0 comments Download
D chrome/browser/sync/internal_api/base_transaction.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/sync/internal_api/base_transaction.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/sync/internal_api/change_record.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/sync/internal_api/change_record.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/sync/internal_api/change_record_unittest.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/sync/internal_api/change_reorder_buffer.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/sync/internal_api/change_reorder_buffer.cc View 1 2 3 4 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/browser/sync/internal_api/configure_reason.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/sync/internal_api/http_post_provider_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/sync/internal_api/http_post_provider_interface.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/sync/internal_api/js_mutation_event_observer.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/sync/internal_api/js_mutation_event_observer.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/sync/internal_api/js_mutation_event_observer_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/sync/internal_api/js_sync_manager_observer.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/sync/internal_api/js_sync_manager_observer.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D chrome/browser/sync/internal_api/read_node.h View 1 2 3 4 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/sync/internal_api/read_node.cc View 1 2 3 4 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/sync/internal_api/read_transaction.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/sync/internal_api/read_transaction.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/sync/internal_api/sync_manager.h View 1 chunk +0 lines, -644 lines 0 comments Download
D chrome/browser/sync/internal_api/sync_manager.cc View 1 2 3 4 1 chunk +0 lines, -2575 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_internal.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_internal.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_server_connection_manager.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_server_connection_manager.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/sync/internal_api/syncapi_unittest.cc View 1 2 3 4 1 chunk +0 lines, -2519 lines 0 comments Download
D chrome/browser/sync/internal_api/user_share.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/sync/internal_api/user_share.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/sync/internal_api/write_node.h View 1 2 3 4 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/sync/internal_api/write_node.cc View 1 2 3 4 1 chunk +0 lines, -503 lines 0 comments Download
D chrome/browser/sync/internal_api/write_transaction.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/sync/internal_api/write_transaction.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/sync/test/engine/test_user_share.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/sync/test/engine/test_user_share.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 2 chunks +1 line, -67 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 8 chunks +7 lines, -67 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
A sync/internal_api/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A + sync/internal_api/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/all_status.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/all_status.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/base_node.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/base_node.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + sync/internal_api/base_transaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/base_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/change_record.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/change_record.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + sync/internal_api/change_record_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/change_reorder_buffer.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + sync/internal_api/change_reorder_buffer.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + sync/internal_api/configure_reason.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/debug_info_event_listener.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/debug_info_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/debug_info_event_listener_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + sync/internal_api/http_post_provider_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/http_post_provider_interface.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/js_mutation_event_observer.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/js_mutation_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/js_mutation_event_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/js_sync_manager_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/js_sync_manager_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/read_node.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/read_node.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + sync/internal_api/read_transaction.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + sync/internal_api/read_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/sync_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + sync/internal_api/sync_manager.cc View 1 2 3 4 2 chunks +15 lines, -15 lines 0 comments Download
A + sync/internal_api/syncapi_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/syncapi_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/syncapi_server_connection_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/syncapi_server_connection_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + sync/internal_api/syncapi_server_connection_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/syncapi_unittest.cc View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
A + sync/internal_api/test_user_share.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/test_user_share.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
A + sync/internal_api/user_share.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/user_share.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/write_node.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/write_node.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
A + sync/internal_api/write_transaction.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + sync/internal_api/write_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync.gyp View 1 2 3 4 5 6 7 3 chunks +139 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
akalin
+tim for review
8 years, 8 months ago (2012-04-19 22:49:57 UTC) #1
akalin
ping! (this will go stale quickly)
8 years, 8 months ago (2012-04-20 20:17:48 UTC) #2
tim (not reviewing)
On 2012/04/20 20:17:48, akalin wrote: > ping! (this will go stale quickly) I'm a bit ...
8 years, 8 months ago (2012-04-20 20:20:41 UTC) #3
tim (not reviewing)
http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h#newcode36 chrome/browser/sync/profile_sync_service.h:36: #include "sync/internal_api/sync_manager.h" Do we actually need this in here? ...
8 years, 8 months ago (2012-04-20 21:09:12 UTC) #4
tim (not reviewing)
On 2012/04/20 21:09:12, timsteele wrote: > http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h > File chrome/browser/sync/profile_sync_service.h (right): > > http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h#newcode36 > ...
8 years, 8 months ago (2012-04-20 21:09:53 UTC) #5
akalin
Addressed all comments, landing after trybots http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/10147003/diff/6001/chrome/browser/sync/profile_sync_service.h#newcode36 chrome/browser/sync/profile_sync_service.h:36: #include "sync/internal_api/sync_manager.h" On ...
8 years, 8 months ago (2012-04-20 21:55:56 UTC) #6
akalin
I don't remember if we reached consensus: should I land this now or wait? If ...
8 years, 8 months ago (2012-04-21 02:08:34 UTC) #7
akalin
8 years, 8 months ago (2012-04-21 02:44:24 UTC) #8 
per our chat, landing after trybots

Powered by Google App Engine
This is Rietveld 408576698