Issue 10139025: Add support for a context menu on the browser shortcut icon

Issue 10139025: Add support for a context menu on the browser shortcut icon (Closed)

Created:
8 years, 8 months ago by DaveMoore

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for a context menu on the browser shortcut icon BUG=117303 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133515

Patch Set 2 : Only have new api on ChromeLauncherDelegate #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
M	ash/launcher/launcher_view.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h	View	1	1 chunk	+7 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc	View		2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

https://chromiumcodereview.appspot.com/10139025/diff/1/ash/launcher/launcher_delegate.h File ash/launcher/launcher_delegate.h (right): https://chromiumcodereview.appspot.com/10139025/diff/1/ash/launcher/launcher_delegate.h#newcode33 ash/launcher/launcher_delegate.h:33: virtual void CreateNewIncognitoWindow() = 0; Since this and IsLogginedInAsGuest ...

8 years, 8 months ago (2012-04-23 14:15:27 UTC) #2

DaveMoore

http://codereview.chromium.org/10139025/diff/1/ash/launcher/launcher_delegate.h File ash/launcher/launcher_delegate.h (right): http://codereview.chromium.org/10139025/diff/1/ash/launcher/launcher_delegate.h#newcode33 ash/launcher/launcher_delegate.h:33: virtual void CreateNewIncognitoWindow() = 0; On 2012/04/23 14:15:27, sky ...

8 years, 8 months ago (2012-04-23 17:48:08 UTC) #3

sky

8 years, 8 months ago (2012-04-23 20:41:16 UTC) #4

LGTM

http://codereview.chromium.org/10139025/diff/5001/chrome/browser/ui/views/ash...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h (right):

http://codereview.chromium.org/10139025/diff/5001/chrome/browser/ui/views/ash...
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h:144: virtual
bool IsLoggedInAsGuest();
remove virtual here and 148.

Expand Messages | Collapse Messages