Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc

Issue 10139025: Add support for a context menu on the browser shortcut icon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only have new api on ChromeLauncherDelegate Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc
diff --git a/chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc b/chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc
index 9bfd6435930183598e4059c6adb24de315bf7640..30fe5c4302594c0bc7efe9f125a7959c65929a92 100644
--- a/chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc
+++ b/chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc
@@ -37,6 +37,13 @@ LauncherContextMenu::LauncherContextMenu(ChromeLauncherDelegate* delegate,
AddCheckItemWithStringId(
LAUNCH_TYPE_FULLSCREEN,
IDS_APP_CONTEXT_MENU_OPEN_FULLSCREEN);
+ } else if (item_.type == ash::TYPE_BROWSER_SHORTCUT) {
+ AddItem(MENU_NEW_WINDOW,
+ l10n_util::GetStringUTF16(IDS_LAUNCHER_NEW_WINDOW));
+ if (!delegate_->IsLoggedInAsGuest()) {
+ AddItem(MENU_NEW_INCOGNITO_WINDOW,
+ l10n_util::GetStringUTF16(IDS_LAUNCHER_NEW_INCOGNITO_WINDOW));
+ }
} else {
AddItem(MENU_OPEN, delegate->GetTitle(item_));
if (delegate->IsOpen(item_.id)) {
@@ -108,6 +115,13 @@ void LauncherContextMenu::ExecuteCommand(int command_id) {
delegate_->SetLaunchType(item_.id, ExtensionPrefs::LAUNCH_FULLSCREEN);
break;
case MENU_AUTO_HIDE:
- return ash::LauncherContextMenu::ToggleAutoHideMenu();
+ ash::LauncherContextMenu::ToggleAutoHideMenu();
+ break;
+ case MENU_NEW_WINDOW:
+ delegate_->CreateNewWindow();
+ break;
+ case MENU_NEW_INCOGNITO_WINDOW:
+ delegate_->CreateNewIncognitoWindow();
+ break;
}
}

Powered by Google App Engine
This is Rietveld 408576698