Issue 10134028: Reimplement ActivateCellularModem without Libcros

Issue 10134028: Reimplement ActivateCellularModem without Libcros (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reimplement ActivateCellularModem without Libcros BUG=chromium-os:16557 TEST=unit_tests --gtest_filter="CrosNetworkFunctions*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133631

Patch Set 2 : Add crosbug.com URLs to TODO comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -1 line)			Patch
M	chrome/browser/chromeos/cros/cros_network_functions.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/cros_network_functions_unittest.cc	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_chromeos_network.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_chromeos_network.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_ipconfig_client.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_network_client.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_service_client.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_service_client.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_service_client_unittest.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_flimflam_service_client.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm with added comment http://codereview.chromium.org/10134028/diff/1/chromeos/dbus/flimflam_service_client.h File chromeos/dbus/flimflam_service_client.h (right): http://codereview.chromium.org/10134028/diff/1/chromeos/dbus/flimflam_service_client.h#newcode100 chromeos/dbus/flimflam_service_client.h:100: // TODO(hashimoto): Refactor CrosActivateCellularModem and ...

8 years, 8 months ago (2012-04-23 21:46:18 UTC) #2

hashimoto

8 years, 8 months ago (2012-04-24 04:52:39 UTC) #3

http://codereview.chromium.org/10134028/diff/1/chromeos/dbus/flimflam_service...
File chromeos/dbus/flimflam_service_client.h (right):

http://codereview.chromium.org/10134028/diff/1/chromeos/dbus/flimflam_service...
chromeos/dbus/flimflam_service_client.h:100: // TODO(hashimoto): Refactor
CrosActivateCellularModem and remove this method.
On 2012/04/23 21:46:18, stevenjb (chromium) wrote:
> This is going to be a non-trivial but important change; we should file an
issue
> for it and reference it here.

Done.

Expand Messages | Collapse Messages