Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chromeos/dbus/flimflam_service_client.cc

Issue 10134028: Reimplement ActivateCellularModem without Libcros (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add crosbug.com URLs to TODO comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/flimflam_service_client.h ('k') | chromeos/dbus/flimflam_service_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/flimflam_service_client.cc
diff --git a/chromeos/dbus/flimflam_service_client.cc b/chromeos/dbus/flimflam_service_client.cc
index ec8e1c92b54eca84ed6d3251f19a622d6a656ad7..64a15280e10932ac0f7c62e52b13684c3a90cac2 100644
--- a/chromeos/dbus/flimflam_service_client.cc
+++ b/chromeos/dbus/flimflam_service_client.cc
@@ -108,6 +108,17 @@ class FlimflamServiceClientImpl : public FlimflamServiceClient {
GetHelper(service_path)->CallVoidMethod(&method_call, callback);
}
+ // FlimflamServiceClient override.
+ virtual bool CallActivateCellularModemAndBlock(
+ const dbus::ObjectPath& service_path,
+ const std::string& carrier) OVERRIDE {
+ dbus::MethodCall method_call(flimflam::kFlimflamServiceInterface,
+ flimflam::kActivateCellularModemFunction);
+ dbus::MessageWriter writer(&method_call);
+ writer.AppendString(carrier);
+ return GetHelper(service_path)->CallVoidMethodAndBlock(&method_call);
+ }
+
private:
typedef std::map<std::string, FlimflamClientHelper*> HelperMap;
@@ -200,6 +211,13 @@ class FlimflamServiceClientStubImpl : public FlimflamServiceClient {
PostSuccessVoidCallback(callback);
}
+ // FlimflamServiceClient override.
+ virtual bool CallActivateCellularModemAndBlock(
+ const dbus::ObjectPath& service_path,
+ const std::string& carrier) OVERRIDE {
+ return true;
+ }
+
private:
void PassEmptyDictionaryValue(const DictionaryValueCallback& callback) const {
base::DictionaryValue dictionary;
« no previous file with comments | « chromeos/dbus/flimflam_service_client.h ('k') | chromeos/dbus/flimflam_service_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698