Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10134022: fix tests and return new syscalls back (Closed)

Created:
8 years, 8 months ago by vissi
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

berkeley sockets interception implementation Adds hooks for all the socket-related functions. By default hooks return ENOSYS, but can be intercepted in the application. Return these: e98ec8c fixed signatures for several syscalls that return positive value in correct case 256e1ec removed epoll_create1 (EPOLL_CLOEXEC is not applicable to NaCl, as there is no possibility to fork); added recv and send to syscalls.list 0533bbb added several system call hooks for future sockets implementation BUG= TEST=trybot Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=1de757e

Patch Set 1 #

Patch Set 2 : fixed description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -51 lines) Patch
M elf/Versions View 3 chunks +31 lines, -1 line 0 comments Download
M make_sysd_rules.py View 1 chunk +0 lines, -17 lines 0 comments Download
M sysdeps/nacl/irt_syscalls.h View 5 chunks +67 lines, -1 line 0 comments Download
M sysdeps/nacl/irt_syscalls.c View 3 chunks +91 lines, -0 lines 0 comments Download
M sysdeps/nacl/syscalls.list View 1 chunk +19 lines, -0 lines 0 comments Download
M sysdeps/nacl/sysdep.h View 10 chunks +171 lines, -29 lines 0 comments Download
M sysdeps/unix/make-syscalls.sh View 1 chunk +1 line, -1 line 0 comments Download
M sysdeps/unix/sysv/linux/ifaddrs.c View 2 chunks +0 lines, -2 lines 0 comments Download
M sysdeps/unix/sysv/linux/sys/syscall.h View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vissi
Hi! Buildbot button didn't attach, but you can see here: http://build.chromium.org/p/tryserver.nacl/builders/nacl-toolchain-lucid64-glibc/builds/20 that small tests passed. ...
8 years, 8 months ago (2012-04-22 09:48:55 UTC) #1
khim
8 years, 8 months ago (2012-04-22 15:58:30 UTC) #2
Please include description from the original CLs.

LGTM except for CL description: it's not a small fix for the bug, it's
full-blown implementation of the socket interception feature, it's description
should reflect this fact.

Powered by Google App Engine
This is Rietveld 408576698