Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10126011: Remove suppression code for VM crash! Celebrate! (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/scripts/buildbot_annotated_steps.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 6757)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -257,21 +257,6 @@
bool get hasCrashed() {
if (Platform.operatingSystem() == 'windows') {
- if (exitCode != 0) {
- // Suppress some flaky errors that crash the VM.
- // TODO(sigmund,efortuna): remove this when bug 2124 gets fixed.
- for (String line in testCase.output.stdout) {
- if (line.startsWith('Kind:')) {
- if (!alreadyPrintedWarning) {
- print("WARNING: VM crashed: $line, exit code: $exitCode. "
- " This is a fake pass!!");
- alreadyPrintedWarning = true;
- }
- return false;
- }
- }
- }
-
// The VM uses std::abort to terminate on asserts.
// std::abort terminates with exit code 3 on Windows.
if (exitCode == 3) {
@@ -291,24 +276,7 @@
}
// Reverse result of a negative test.
- bool get hasFailed() {
- // TODO(efortuna): This is a total hack to keep our buildbots (more) green
- // while the VM team solves Issue 2124. Remove when issue is fixed.
- if (Platform.operatingSystem() == 'windows' && (exitCode == 253 ||
- exitCode == 3)) {
- for (String line in testCase.output.stdout) {
- if (line.startsWith('VM exited with signal 1073741819') ||
- line.startsWith('Kind:')) {
- if (!alreadyPrintedWarning) {
- print("WARNING: VM crashed: $line This is a fake pass!!");
- alreadyPrintedWarning = true;
- }
- return testCase.expectedOutcomes.iterator().next() == FAIL;
- }
- }
- }
- return (testCase.isNegative ? !didFail : didFail);
- }
+ bool get hasFailed() => testCase.isNegative ? !didFail : didFail;
}
« no previous file with comments | « frog/scripts/buildbot_annotated_steps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698