Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: frog/scripts/buildbot_annotated_steps.py

Issue 10126011: Remove suppression code for VM crash! Celebrate! (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/scripts/buildbot_annotated_steps.py
===================================================================
--- frog/scripts/buildbot_annotated_steps.py (revision 6757)
+++ frog/scripts/buildbot_annotated_steps.py (working copy)
@@ -90,13 +90,6 @@
# TODO(jmesserly): do we want to do anything different for the second IE
# bot? For now we're using it to track down flakiness.
number = web_pattern.group(4)
-
- # TODO(efortuna): This is a temporary repurposing of one of the IE bots so
- # that the VM team can debug the VM crash on Windows (and not have to
- # modify the buildbot master code). Get rid of this code once it is fixed.
- if number == '2':
- mode = 'debug'
- runtime = 'chrome' # Use chrome for runtime because it's the fastest.
if system == 'windows':
system = 'win7'
@@ -158,8 +151,8 @@
"""
# TODO(efortuna): Currently we always clobber Windows builds. The VM
# team thinks there's a problem with dependency tracking on Windows that
- # is leading to these VM heisenbugs. Remove this when the dependency issue has
- # been ironed out. See bug 2124.
+ # is leading to occasional build failures. Remove when this gyp issue has
+ # been ironed out.
if system == 'win7':
for build in ['Release_', 'Debug_']:
for arch in ['ia32', 'x64']:
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698