Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/upload_sdk.py

Issue 10117031: Move 'revision' file creation from upload_sdk into create_sdk (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/create_sdk.py ('k') | tools/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/upload_sdk.py
===================================================================
--- tools/upload_sdk.py (revision 6711)
+++ tools/upload_sdk.py (working copy)
@@ -52,16 +52,7 @@
(status, output) = ExecuteCommand(cmd)
return status
-def GetSVNRevision():
- p = subprocess.Popen(['svn', 'info'], stdout = subprocess.PIPE,
- stderr = subprocess.STDOUT, shell=HAS_SHELL)
- output, not_used = p.communicate()
- for line in output.split('\n'):
- if 'Revision' in line:
- return (line.strip().split())[1]
- return None
-
def Usage(progname):
sys.stderr.write('Usage: %s path_to_sdk\n' % progname)
@@ -82,13 +73,11 @@
#should fail with a message.
#If we are not on a buildbot then fail silently.
exit(0)
- revision = GetSVNRevision()
+ revision = utils.GetSVNRevision()
if revision is None:
sys.stderr.write('Unable to find SVN revision.\n')
return 1
os.chdir(os.path.dirname(argv[1]))
- with open(os.path.join(os.path.basename(argv[1]), 'revision'), 'w') as f:
- f.write(revision + '\n')
if (os.path.basename(os.path.dirname(argv[1])) ==
utils.GetBuildConf('release', 'ia32')):
« no previous file with comments | « tools/create_sdk.py ('k') | tools/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698