Move 'revision' file creation from upload_sdk into create_sdk

tools/upload_sdk.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This zips the SDK and uploads it to Google Storage when run on a buildbot.
 #
 # Usage: upload_sdk.py path_to_sdk
 
@@ skipping 34 matching lines @@
   cmd = [GSUTIL, 'cp', source, target]
   (status, output) = ExecuteCommand(cmd)
   if status != 0:
     return status
   print 'Uploaded: ' + output[0]
 
   cmd = [GSUTIL, 'setacl', 'public-read', target]
   (status, output) = ExecuteCommand(cmd)
   return status
 
-def GetSVNRevision():
-  p = subprocess.Popen(['svn', 'info'], stdout = subprocess.PIPE,
-      stderr = subprocess.STDOUT, shell=HAS_SHELL)
-  output, not_used = p.communicate()
-  for line in output.split('\n'):
-    if 'Revision' in line:
-      return (line.strip().split())[1]
-  return None
-
 
 def Usage(progname):
   sys.stderr.write('Usage: %s path_to_sdk\n' % progname)
 
 
 def main(argv):
   #allow local editor builds to deploy to a different bucket
   if os.environ.has_key('DART_LOCAL_BUILD'):
     gsdir = os.environ['DART_LOCAL_BUILD']
   else:
     gsdir = GS_DIR
     
   if not os.path.exists(argv[1]):
     sys.stderr.write('Path not found: %s\n' % argv[1])
     Usage(argv[0])
     return 1
   if not os.path.exists(GSUTIL):
     #TODO: Determine where we are running, if we're running on a buildbot we
     #should fail with a message.  
     #If we are not on a buildbot then fail silently. 
     exit(0)
-  revision = GetSVNRevision()
+  revision = utils.GetSVNRevision()
   if revision is None:
     sys.stderr.write('Unable to find SVN revision.\n')
     return 1
   os.chdir(os.path.dirname(argv[1]))
-  with open(os.path.join(os.path.basename(argv[1]), 'revision'), 'w') as f:
-    f.write(revision + '\n')
 
   if (os.path.basename(os.path.dirname(argv[1])) ==
       utils.GetBuildConf('release', 'ia32')):
     sdk_suffix = ''
   else:
     sdk_suffix = '-debug'
   # TODO(dgrove) - deal with architectures that are not ia32.
   sdk_file = 'dart-%s-%s%s.zip' % (utils.GuessOS(), revision, sdk_suffix)
   if (os.path.exists(SDK_LOCAL_ZIP)):
     os.remove(SDK_LOCAL_ZIP)
   if platform.system() == 'Windows':
     # Windows does not have zip. We use the 7 zip utility in third party.
     ExecuteCommand([os.path.join('..', 'third_party', '7zip', '7za'), 'a',
         '-tzip', SDK_LOCAL_ZIP, os.path.basename(argv[1])])
   else:
     ExecuteCommand(['zip', '-yr', SDK_LOCAL_ZIP, os.path.basename(argv[1])])
   UploadArchive(SDK_LOCAL_ZIP,
                 GS_SITE + '/'.join([gsdir, GS_SDK_DIR, sdk_file]))
   latest_name = 'dart-%s-latest%s.zip' % (utils.GuessOS(), sdk_suffix)
   UploadArchive(SDK_LOCAL_ZIP,
                 GS_SITE + '/'.join([gsdir, GS_SDK_DIR, latest_name]))
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))