Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 10117022: Cleanup of v8 extension stuff. Playback extension is only used in chrome, so move it to chrome\rend… (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
CC:
chromium-reviews, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Cleanup of v8 extension stuff. Playback extension is only used in chrome, so move it to chrome\renderer and all of its associated switches to chrome. GC extension is only used by webkit\support, so move it there. The other two profiler extensions aren't used, so remove them. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132841

Patch Set 1 : #

Patch Set 2 : remove playback and profiling from test_shell, not used afaik #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -574 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +10 lines, -4 lines 0 comments Download
A + chrome/renderer/playback_extension.h View 2 chunks +4 lines, -6 lines 0 comments Download
A + chrome/renderer/playback_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D webkit/extensions/v8/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/extensions/v8/gc_extension.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/extensions/v8/gc_extension.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/extensions/v8/heap_profiler_extension.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/extensions/v8/heap_profiler_extension.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D webkit/extensions/v8/playback_extension.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/extensions/v8/playback_extension.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/extensions/v8/profiler_extension.h View 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/extensions/v8/profiler_extension.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D webkit/extensions/webkit_extensions_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
A + webkit/support/gc_extension.h View 2 chunks +4 lines, -6 lines 0 comments Download
A + webkit/support/gc_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 4 chunks +0 lines, -55 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
8 years, 8 months ago (2012-04-18 15:58:31 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 8 months ago (2012-04-18 16:05:52 UTC) #2
jam
Tony: can you please look at the webkit changes? I don't think anyone uses test_shell ...
8 years, 8 months ago (2012-04-18 17:22:49 UTC) #3
jam
->jamesr since tony is gone
8 years, 8 months ago (2012-04-18 18:29:54 UTC) #4
jamesr
webkit/ stuff LGTM if you're sure nobody is using it does playback mode work in ...
8 years, 8 months ago (2012-04-18 18:40:14 UTC) #5
jam
8 years, 8 months ago (2012-04-18 19:04:12 UTC) #6
On 2012/04/18 18:40:14, jamesr wrote:
> webkit/ stuff LGTM if you're sure nobody is using it

i couldn't see people using it in test_shell by searching on cs (i could see
tests using it through chrome/browser_tests)

> 
> does playback mode work in content_shell? it's useful for benchmarking

no it doesn't work. is there a need for it?

Powered by Google App Engine
This is Rietveld 408576698