Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4447)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10117022: Cleanup of v8 extension stuff. Playback extension is only used in chrome, so move it to chrome\rend… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/renderer/playback_extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
===================================================================
--- chrome/renderer/chrome_content_renderer_client.cc (revision 132793)
+++ chrome/renderer/chrome_content_renderer_client.cc (working copy)
@@ -47,6 +47,7 @@
#include "chrome/renderer/net/renderer_net_predictor.h"
#include "chrome/renderer/page_click_tracker.h"
#include "chrome/renderer/page_load_histograms.h"
+#include "chrome/renderer/playback_extension.h"
#include "chrome/renderer/plugins/plugin_placeholder.h"
#include "chrome/renderer/plugins/plugin_uma.h"
#include "chrome/renderer/prerender/prerender_dispatcher.h"
@@ -179,12 +180,17 @@
if (search_extension)
thread->RegisterExtension(search_extension);
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableBenchmarking))
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kEnableBenchmarking))
thread->RegisterExtension(extensions_v8::BenchmarkingExtension::Get());
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableIPCFuzzing)) {
+ if (command_line->HasSwitch(switches::kPlaybackMode) ||
+ command_line->HasSwitch(switches::kRecordMode) ||
+ command_line->HasSwitch(switches::kNoJsRandomness)) {
+ thread->RegisterExtension(extensions_v8::PlaybackExtension::Get());
+ }
+
+ if (command_line->HasSwitch(switches::kEnableIPCFuzzing)) {
thread->GetChannel()->set_outgoing_message_filter(LoadExternalIPCFuzzer());
}
// chrome:, chrome-devtools:, and chrome-internal: pages should not be
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/renderer/playback_extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698