Issue 10116026: Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10116026: Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometim… (Closed)

Created:
8 years, 8 months ago by vsevik

Modified:
8 years, 8 months ago

Reviewers:
vsevik

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/

Visibility:
Public.

More Reviews

Description

Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometimes. https://bugs.webkit.org/show_bug.cgi?id=84148 Reviewed by Pavel Feldman. TextPrompt.complete() requests completions asynchronously, this change adds a flag that informs TextPrompt._completionsReady() whether completions should still be shown. * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): TBR=vsevik@chromium.org BUG=123826 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114505

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/WebCore/inspector/front-end/TextPrompt.js	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages