Issue 10110001: Push heap stats as HeapStatsUpdate struct instead of raw array of uint32_t values.

Issue 10110001: Push heap stats as HeapStatsUpdate struct instead of raw array of uint32_t values. (Closed)

Created:
8 years, 8 months ago by loislo

Modified:
8 years, 8 months ago

Reviewers:
alexeif, mnaganov (inactive), yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Push heap stats as HeapStatsUpdate struct instead of raw array of uint32_t values. We are pushing stats data as a raw array of uint32_t values at the moment. It makes tricky the process of updating the API between v8 and WebKit. BUG=none TEST=HeapSnapshotObjectsStats Committed: https://code.google.com/p/v8/source/detail?r=11355

Patch Set 1 #

Patch Set 2 : fix style errors #

Total comments: 4

Patch Set 3 : Fields of HeapStatsUpdate struct were commented. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -35 lines)			Patch
M	include/v8.h	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	include/v8-profiler.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/profile-generator.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/profile-generator.cc	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	12 chunks	+23 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h File include/v8-profiler.h (right): https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h#newcode568 include/v8-profiler.h:568: uint32_t index; Please comment on the fields. https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8.h File ...

8 years, 8 months ago (2012-04-17 12:39:54 UTC) #2

loislo

On 2012/04/17 12:39:54, Yury Semikhatsky wrote: > https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h > File include/v8-profiler.h (right): > > https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h#newcode568 ...

8 years, 8 months ago (2012-04-17 12:49:44 UTC) #3

mnaganov (inactive)

8 years, 8 months ago (2012-04-17 13:05:14 UTC) #4

LGTM, with comments

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler...
include/v8-profiler.h:449: * object. Updates on each time interval are provided
as a triplet. It has
"as a triplet. It has ..." -> "as a stream of the HeapStatsUpdate structure
instances."

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler...
include/v8-profiler.h:563: * A struct for exporting HeapStats data from V8,
using "push" model.
Add "See HeapProfiler::PushHeapObjectsStats."

Expand Messages | Collapse Messages