Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: include/v8.h

Issue 10110001: Push heap stats as HeapStatsUpdate struct instead of raw array of uint32_t values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fields of HeapStatsUpdate struct were commented. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 0f05230596e19496a7a98515dea6fa918b7a6a31..ec2f48d79636f82bffc55fc6f257e280140da174 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3742,13 +3742,18 @@ class V8EXPORT Locker {
/**
+ * A struct for exporting HeapStats data from V8, using "push" model.
+ */
+struct HeapStatsUpdate;
+
+
+/**
* An interface for exporting data from V8, using "push" model.
*/
class V8EXPORT OutputStream { // NOLINT
public:
enum OutputEncoding {
- kAscii = 0, // 7-bit ASCII.
- kUint32 = 1
+ kAscii = 0 // 7-bit ASCII.
};
enum WriteResult {
kContinue = 0,
@@ -3772,9 +3777,7 @@ class V8EXPORT OutputStream { // NOLINT
* can be stopped by returning kAbort as function result. EndOfStream
* will not be called in case writing was aborted.
*/
- // TODO(loislo): Make this pure virtual when WebKit's V8 bindings
- // have been updated.
- virtual WriteResult WriteUint32Chunk(uint32_t* data, int count) {
+ virtual WriteResult WriteHeapStatsChunk(HeapStatsUpdate* data, int count) {
return kAbort;
};
};
« no previous file with comments | « no previous file | include/v8-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698