Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10107027: Generate proper wrapper types for ActiveDOMObjects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index 50538c10babb63b7237f1b8b8884b11398a11b61..2e26421f4f67baf134914d50265b9685622a7e22 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -836,9 +836,15 @@ def _GenerateCPPIncludes(includes):
return ''.join(['#include %s\n' % include for include in includes])
def _DOMWrapperType(database, interface):
+ if interface.id == 'MessagePort':
+ return 'MessagePort'
+
+ type = 'Object'
Anton Muhin 2012/04/17 17:42:06 why it's not DOM{Object,Node} any more?
podivilov 2012/04/18 08:46:53 For brevity. These type names are declared in Dart
Anton Muhin 2012/04/18 09:01:06 ok, thanks On 2012/04/18 08:46:53, podivilov wrot
if _InstanceOfNode(database, interface):
- return 'DOMNode'
- return 'DOMObject'
+ type = 'Node'
+ if 'ActiveDOMObject' in interface.ext_attrs:
+ type = 'Active%s' % type
+ return type
def _InstanceOfNode(database, interface):
if interface.id == 'Node':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698