Generate proper wrapper types for ActiveDOMObjects.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 818 matching lines @@
       arguments.insert(0, 'receiver')
       self._cpp_impl_includes.add('"%s.h"' % attributes['ImplementedBy'])
 
     return emitter.Format(invocation_template,
         FUNCTION_CALL='%s(%s)' % (function_expression, ', '.join(arguments)))
 
 def _GenerateCPPIncludes(includes):
   return ''.join(['#include %s\n' % include for include in includes])
 
 def _DOMWrapperType(database, interface):
+  if interface.id == 'MessagePort':
+    return 'MessagePort'
+
+  type = 'Object'

[Anton Muhin, 2012/04/17 17:42:06]

why it's not DOM{Object,Node} any more?

[podivilov, 2012/04/18 08:46:53]

For brevity. These type names are declared in DartDOMWrapper class, which
already has "DOM" in its name, and are obviously related to DOM.

[Anton Muhin, 2012/04/18 09:01:06]

ok, thanks

On 2012/04/18 08:46:53, podivilov wrote:

   if _InstanceOfNode(database, interface):
-    return 'DOMNode'
-  return 'DOMObject'
+    type = 'Node'
+  if 'ActiveDOMObject' in interface.ext_attrs:
+    type = 'Active%s' % type
+  return type
 
 def _InstanceOfNode(database, interface):
   if interface.id == 'Node':
     return True
   for parent in interface.parents:
     if not database.HasInterface(parent.type.id):
       continue
     parent_interface = database.GetInterface(parent.type.id)
     if _InstanceOfNode(database, parent_interface):
       return True
   return False