Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: content/browser/geolocation/location_arbitrator_unittest.cc

Issue 10107017: Remove requesting_frame parameters from Geolocation stack (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/location_arbitrator_unittest.cc
diff --git a/content/browser/geolocation/location_arbitrator_unittest.cc b/content/browser/geolocation/location_arbitrator_unittest.cc
index a78875b15811f2473130ec7f8919b4077b74e3e6..ab7d7ea83a7c4764a4449b75c081a2a86473113f 100644
--- a/content/browser/geolocation/location_arbitrator_unittest.cc
+++ b/content/browser/geolocation/location_arbitrator_unittest.cc
@@ -155,7 +155,7 @@ TEST_F(GeolocationLocationArbitratorTest, CreateDestroy) {
TEST_F(GeolocationLocationArbitratorTest, OnPermissionGranted) {
EXPECT_FALSE(arbitrator_->HasPermissionBeenGranted());
- arbitrator_->OnPermissionGranted(GURL("http://frame.test"));
+ arbitrator_->OnPermissionGranted();
EXPECT_TRUE(arbitrator_->HasPermissionBeenGranted());
// Can't check the provider has been notified without going through the
// motions to create the provider (see next test).
@@ -188,16 +188,11 @@ TEST_F(GeolocationLocationArbitratorTest, NormalUsage) {
EXPECT_EQ(cell()->position_.latitude,
observer_->last_position_.latitude);
- EXPECT_FALSE(
- cell()->permission_granted_url_.is_valid());
+ EXPECT_FALSE(cell()->is_permission_granted_);
EXPECT_FALSE(arbitrator_->HasPermissionBeenGranted());
- GURL frame_url("http://frame.test");
- arbitrator_->OnPermissionGranted(frame_url);
+ arbitrator_->OnPermissionGranted();
EXPECT_TRUE(arbitrator_->HasPermissionBeenGranted());
- EXPECT_TRUE(
- cell()->permission_granted_url_.is_valid());
- EXPECT_EQ(frame_url,
- cell()->permission_granted_url_);
+ EXPECT_TRUE(cell()->is_permission_granted_);
}
TEST_F(GeolocationLocationArbitratorTest, SetObserverOptions) {

Powered by Google App Engine
This is Rietveld 408576698